Skip to content

Conversation

@ichinii
Copy link
Collaborator

@ichinii ichinii commented Nov 12, 2025

Type of Change

  • Bug fix (non breaking change, fixing an issue)
  • New feature
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Documentation / Wiki update

Description

Targets (rayx-core-tst, rayx (cli) rayx-ui) can now be enabled/disabled via cmake option.
which dependencies will be included now depends on the enabled targets


✅ Pre-Merge Checklist

Important

By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.

Please complete each item before requesting a review.

  • Code follows the project's coding standards
  • Unit tests for new functionality are added and pass
  • All existing tests pass
  • Resolved TODO Comments (prefer new issues instead)
  • Documentation, if applicable, including:
    • Doxygen comments for any new rayx-core API functions
    • Helpful inline comments where needed for clarity
    • Wiki pages, e.g. updated build instructions, new Element etc.
  • Commits:
    • Use clear and readable commit messages (e.g. Conventional commits)
    • Squash and rebase onto master if individual commits don’t add value
    • Ensure linear commit history (required by master)

before, cmake determined RPATH automatically, using absolute paths
this creates RPATHs which are not portable.
Now CMake will add a relative RPATH.
Additionally, following RPATHs are added:
$ORIGIN # search next to the executable
$ORIGIN/lib
$ORIGIN/../lib
@ichinii ichinii force-pushed the enable_targets_on_configure_time branch from 103b83e to 236bbd8 Compare November 13, 2025 12:53
@ichinii ichinii changed the title make targets optional at cmake configure time add flake.nix Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants